Reduce rerenders in the metadata tab#1608
Merged
gregorydlogan merged 3 commits intoopencast:r/18.xfrom Dec 8, 2025
Merged
Conversation
02ebbe8 to
317b327
Compare
This patch rewrites the Metadata component. This accomplishes: - Stop the whole Metadata component from rerendering each time redux state is updated. This was causing ui elements to become unresponsive in certain cases (e.g. having tens of thousands of series in your Opencast). - Makes the code in the Metadata component far less difficult to read.
317b327 to
2ed720a
Compare
|
This pull request is deployed at test.editor.opencast.org/1608/2025-08-08_12-37-00/ . |
|
This pull request has conflicts ☹ |
|
This pull request is deployed at test.editor.opencast.org/1608/2025-09-26_10-00-47/ . |
Member
|
Seeing an exception when changing the start date: No present without this PR. |
The backend would report "Not able to parse date string 2021-06-15T13:33: ParseException: Unparseable date: "2021-06-15T13:33"". This fixes that, by making sure the date stored in redux is a proper ISO date again.
Member
Author
|
Thanks for testing that, should be fixed now. |
|
This pull request is deployed at test.editor.opencast.org/1608/2025-10-29_13-32-15/ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch rewrites the Metadata component. This accomplishes:
How to test this
Can be tested as usual. Make sure that editing and saving Metadata still works as expected.