Skip to content

Reduce rerenders in the metadata tab#1608

Merged
gregorydlogan merged 3 commits intoopencast:r/18.xfrom
Arnei:metadata-rework-reduce-rerenders
Dec 8, 2025
Merged

Reduce rerenders in the metadata tab#1608
gregorydlogan merged 3 commits intoopencast:r/18.xfrom
Arnei:metadata-rework-reduce-rerenders

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Jul 18, 2025

This patch rewrites the Metadata component. This accomplishes:

  • Stop the whole Metadata component from rerendering each time redux state is updated. This was causing ui elements to become unresponsive in certain cases (e.g. having tens of thousands of series in your Opencast).
  • Makes the code in the Metadata component far less difficult to read..

How to test this

Can be tested as usual. Make sure that editing and saving Metadata still works as expected.

@Arnei Arnei added type:enhancement New feature or request type:code-quality Internal improvements to the codebase labels Jul 18, 2025
@Arnei Arnei force-pushed the metadata-rework-reduce-rerenders branch from 02ebbe8 to 317b327 Compare July 18, 2025 10:12
This patch rewrites the Metadata component. This accomplishes:
- Stop the whole Metadata component from rerendering
each time redux state is updated. This was causing ui elements to
become unresponsive in certain cases (e.g. having tens of thousands of
series in your Opencast).
- Makes the code in the Metadata component far less
difficult to read.
@Arnei Arnei force-pushed the metadata-rework-reduce-rerenders branch from 317b327 to 2ed720a Compare August 8, 2025 12:36
@Arnei Arnei changed the base branch from develop to r/18.x August 8, 2025 12:37
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 8, 2025

This pull request is deployed at test.editor.opencast.org/1608/2025-08-08_12-37-00/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Sep 26, 2025
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/1608/2025-09-26_10-00-47/ .
It might take a few minutes for it to become available.

@gregorydlogan
Copy link
Copy Markdown
Member

Seeing an exception when changing the start date:

2025-10-20 11:28:11,515 | INFO  | (AssetManagerImpl:452) - Trigger update handlers for snapshot ID-dog-rose-1310279468, version 3
2025-10-20 11:28:11,574 | ERROR | (MetadataJson:365) - Not able to parse date string 2021-06-15T13:33: ParseException: Unparseable date: "2021-06-15T13:33"
2025-10-20 11:28:11,575 | ERROR | (MetadataJson:283) - Not able to parse date 2021-06-14T13:33: Unparseable date: "2021-06-14T13:33"
2025-10-20 11:28:11,608 | INFO  | (AssetManagerImpl:1321) - Creating new version 4 of media package ID-dog-rose-1310279468

No present without this PR.

The backend would report
"Not able to parse date string 2021-06-15T13:33: ParseException: Unparseable date: "2021-06-15T13:33"".

This fixes that, by making sure the date stored in redux is
a proper ISO date again.
@Arnei
Copy link
Copy Markdown
Member Author

Arnei commented Oct 29, 2025

Thanks for testing that, should be fixed now.

@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/1608/2025-10-29_13-32-15/ .
It might take a few minutes for it to become available.

@gregorydlogan gregorydlogan merged commit f5e5a02 into opencast:r/18.x Dec 8, 2025
8 checks passed
@gregorydlogan gregorydlogan self-assigned this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:code-quality Internal improvements to the codebase type:enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants